[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-16 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1354807591 @rmuir would it be possible to backport it to 9.5? thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-15 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1353254656 @rmuir @uschindler thanks a lot for HUGE help here guys! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-14 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1352291207 > sorry i didnt do the other tests, I gotta run for now. i can do them later tonight or tomorrow if you need but just wanted to prototype it out @rmuir tests have been migrated, thank

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-14 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1352258413 > I pushed a proposal to your branch (only fixing one of the tests in .js to use it). If you are really against it, just revert the commit. But i think it keeps tests simpler. :+1: N

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-14 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1352084948 @rmuir first pass over pickiness, all tests are now run w/o diagnostics listener (picky / not picky mode), the rough observations so far are encouraging, there are no significant changes in

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-13 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1349804323 Thanks for encouraging @rmuir ! I will be working on the matter this week and share my findings, thank you! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-13 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1349601503 > Looks like this in painless: https://github.com/opensearch-project/OpenSearch/blob/04757607c5aead788b465c77cec6ef459720f625/modules/lang-painless/src/main/java/org/opensearch/painless/antl

[GitHub] [lucene] reta commented on pull request #12016: Upgrade ANTLR to version 4.11.1

2022-12-13 Thread GitBox
reta commented on PR #12016: URL: https://github.com/apache/lucene/pull/12016#issuecomment-1349213966 @rmuir @uschindler what kind of (performance? jmh?) testing would help to discard / prove that moving to 4.11.x makes / does not make sense. You have definitely seen traps in the past, I wo