[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819498097 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws

[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r819493935 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -181,19 +144,27 @@ public void add(DocIdSetIterator iter) throws

[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r814040808 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -266,20 +224,12 @@ private void upgradeToBitSet() { public DocIdSet

[GitHub] [lucene] rmuir commented on a change in pull request #709: LUCENE-10311: remove complex cost estimation and abstraction leakage around it

rmuir commented on a change in pull request #709: URL: https://github.com/apache/lucene/pull/709#discussion_r814039139 ## File path: lucene/core/src/java/org/apache/lucene/util/DocIdSetBuilder.java ## @@ -266,20 +224,12 @@ private void upgradeToBitSet() { public DocIdSet