rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-974115268
thank you @dweiss and @sarowe for reviewing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-974001822
@dweiss see https://issues.apache.org/jira/browse/LUCENE-5897 for more
background on that
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-973323310
For convenience of reviewing: here is the diff between default skeleton and
"buffer-expansion-disabled" skeleton. It is kinda the only way to review it
since we brought in all the up
rmuir commented on pull request #452:
URL: https://github.com/apache/lucene/pull/452#issuecomment-972384034
I thought to try to do a large refactoring here and quickly backed off, I
think let's just upgrade to the latest jflex as a standalone change.
The trickiest parts (and ones ne
