[GitHub] [lucene] rmuir commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-03 Thread GitBox
rmuir commented on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1058821263 I'm suspicious of the reported performance improvement based on looking at your benchmark output, I don't think its realistic. Looks like nothing else was indexed in any other way (

[GitHub] [lucene] rmuir commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

2022-03-03 Thread GitBox
rmuir commented on pull request #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1058815901 Sorry I see it differently. I'm not a fan of IndexWriter handling the temporary files/encoding/decoding data, this seems to be in the wrong place. If IndexWriter should