[GitHub] [lucene] rmuir commented on pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

rmuir commented on PR #805: URL: https://github.com/apache/lucene/pull/805#issuecomment-1105209410 I defer to Mike, he understands this Viterbi. I am happy to see this refactoring, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [lucene] rmuir commented on pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

rmuir commented on PR #805: URL: https://github.com/apache/lucene/pull/805#issuecomment-1100064836 I think @mikemccand actually created most of this code and is most familiar with it. Mike, if you have time can you look too? For the special n-best class, is the issue that `nori` simpl

[GitHub] [lucene] rmuir commented on pull request #805: LUCENE-10493: factor out Viterbi algorithm and share it between kuromoji and nori

rmuir commented on PR #805: URL: https://github.com/apache/lucene/pull/805#issuecomment-1100062662 Sure, sorry for the slow response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific