rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1105198961
OK let's merge this for now and investigate the properties refactoring as a
separate change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104096183
i'm fine with starting the properties file here, but the problem is not
exactly new. really fixing all the stuff like smoketester, eclipse linter
config, etc etc is gonna be some amount of wor
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104092136
OK now there is ... but you created the monster :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104088255
There's no version numbers in the .bat script. Hence no need for it to be
able to suck in .properties file?
--
This is an automated message from the Apache Git Service.
To respond to the mes
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1104016177
> Windows will be a problem, as it always is, argh.
why is windows a problem? this PR works perfectly fine on windows. I didnt
touch the .bat file because, unlike the .sh file, it has no
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103914462
> +1 to a single source of source/target Java version(s). A simple key-value
format may be easily used from the outside world of java/gradle - github
actions scripts or the smoke tester, and s
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103301886
OK, i cleaned up the messaging here to emit better messages so we don't lead
users through a maze of downloading and retrying. I didn't touch the gradle
checks. And yeah, it would be great to
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103286863
OK, @dweiss can you take another look when you get a chance?
java 8:
```
$ ./gradlew check
Unrecognized option: --source
Error: Could not create the Java Virtual Machine.
E
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1103272545
> I agree with this (as someone who disables the daemon and runs the
commands every time). The only reason I specified it as a different command was
due to the fact that if the downloader fail
rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1102995607
> Yep. I wonder if we could do it in one script (the downloader?) to avoid
running java so many times but overall I think it's better than before. :)
I agree with this (as someone who di
10 matches
Mail list logo
