[GitHub] [lucene] rmuir commented on pull request #836: LUCENE-10533: SpellChecker.formGrams is missing bounds check

2022-04-25 Thread GitBox
rmuir commented on PR #836: URL: https://github.com/apache/lucene/pull/836#issuecomment-1108916100 OK i looked into some surrounding behavior in suggest module: Looks like returning empty list is what DirectSpellChecker does: https://github.com/apache/lucene/blob/main/lucene/su

[GitHub] [lucene] rmuir commented on pull request #836: LUCENE-10533: SpellChecker.formGrams is missing bounds check

2022-04-25 Thread GitBox
rmuir commented on PR #836: URL: https://github.com/apache/lucene/pull/836#issuecomment-1108899794 Should we really return no-results if a user asks to spellcheck the empty string? Or maybe just a better, more obvious exception? -- This is an automated message from the Apache Git Service.