[GitHub] [lucene] romseygeek commented on pull request #603: LUCENE-10377: Replace 'sortPos' with 'enableSkipping' in SortField.getComparator()

2022-01-14 Thread GitBox
romseygeek commented on pull request #603: URL: https://github.com/apache/lucene/pull/603#issuecomment-1012964049 > I think you have already done this removal in this PR, haven't you? Yes, sorry I meant to comment to call it out - it turned out to be a really easy change so I folded

[GitHub] [lucene] romseygeek commented on pull request #603: LUCENE-10377: Replace 'sortPos' with 'enableSkipping' in SortField.getComparator()

2022-01-13 Thread GitBox
romseygeek commented on pull request #603: URL: https://github.com/apache/lucene/pull/603#issuecomment-1012140425 This might make it possible to remove the `getPointsValues()` override from NumericLeafComparator as well as a follow-up, cc @mayya-sharipova -- This is an automated message