[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930947493 ## lucene/CHANGES.txt: ## @@ -39,6 +39,8 @@ New Features * LUCENE-10626 Hunspell: add tools to aid dictionary editing: analysis introspection, stem expansion and stem/f

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930938148 ## lucene/facet/src/java/org/apache/lucene/facet/FacetCountsWithFilterQuery.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-27 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r930937074 ## lucene/facet/src/java/org/apache/lucene/facet/FacetCountsWithFilterQuery.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] shaie commented on a diff in pull request #1015: [LUCENE-10629]: Add fast match query support to FacetSets

2022-07-11 Thread GitBox
shaie commented on code in PR #1015: URL: https://github.com/apache/lucene/pull/1015#discussion_r918535845 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -52,8 +52,10 @@ public MatchingFacetSetsCounts( String field, Fa