uschindler commented on PR #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1264435224
Closing this as the JDK 19 impl was merged (#912).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084758218
Thanks @rmuir for the clirifaction.
To add, because also @mcimadamore asked: We use shared segments, because we
only allocate and map the segment once. It is then used
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-1084563803
> I'm working on a similar approach for my data store, but I'm currently not
sure if it's a good idea for multiple readers plus a single reader/writer to
map a segment for
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-33220
But on long term we should do everything off-heap. Especially the vector
stuff. But for that we need to change IndexInput to allow to return Float
vector or LongVector
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-32159
Thanks Mike. It is mich more stable now (std dev) and on average 0%. We
should figure out why it gets faster on some parts while slower on other parts.
What is different:
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-999391791
I corrected the test to assert the `jdk.unsupported.foreign` module. But as
this won't compile without it, it is in fact obsolete. But for easier merging
in future I left it. I
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-999371293
Hi, that's sorry. I just merged yesterday but didn't run tests. The test is
obsolete on branch.
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-999066439
Thanks Mike, I saw similar results a month ago.
It is very important to do the following:
- don't disable tiered compilation and don't enable batch
- use large index
uschindler commented on pull request #518:
URL: https://github.com/apache/lucene/pull/518#issuecomment-986289333
In contrast to previous drafts, the branch was squashed into one commit.
This makes review easier.
--
This is an automated message from the Apache Git Service.
To respond to
