[GitHub] [lucene] uschindler commented on pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput

uschindler commented on PR #602: URL: https://github.com/apache/lucene/pull/602#issuecomment-1289308655 Sorry, I forgot about this PR. Thanks for merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] uschindler commented on pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput

uschindler commented on pull request #602: URL: https://github.com/apache/lucene/pull/602#issuecomment-1014573645 I would also take this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [lucene] uschindler commented on pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput

uschindler commented on pull request #602: URL: https://github.com/apache/lucene/pull/602#issuecomment-1013117133 Thanks. So unrolling brings no difference and as the bug is gone, we can replace all of those implementations. About the ByteBufferIndexInput for MMapDirectory: This is r

[GitHub] [lucene] uschindler commented on pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput

uschindler commented on pull request #602: URL: https://github.com/apache/lucene/pull/602#issuecomment-1012341843 Great that the original code was still there in a comment. 🤗 This makes easy to review. I don't fully understand the variant that supports negative values. Do we still n