[GitHub] [lucene] uschindler edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-12 Thread GitBox
uschindler edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1010776138 Hi @gf2121, thanks for taking the time to test more. It looks really like the guard checks are not affecting the whole thing, but as always we don't really know where

[GitHub] [lucene] uschindler edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-11 Thread GitBox
uschindler edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009921377 The param must go away or change - to +. Mike's commit fixed the tiered compilation problem and I was not sure if you have used his latest commit. To get better pr

[GitHub] [lucene] uschindler edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-11 Thread GitBox
uschindler edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556 The problem here is that we just reducing the number of guard checks and at same time raising the risk to segv: ReadVint uses multiple atomic reads and all of those read

[GitHub] [lucene] uschindler edited a comment on pull request #592: LUCENE-10366: Reduce the number of valid checks for ByteBufferIndexInput#readVInt

2022-01-11 Thread GitBox
uschindler edited a comment on pull request #592: URL: https://github.com/apache/lucene/pull/592#issuecomment-1009767556 The problem here is that we just reducing the number of guard checks and at same time raising the risk to segv: ReadVint uses multiple atomic reads and all of those read