vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1068300899
I think this PR has reasonable test coverage and can come out of WIP now.
Will continue to iterate on the PR comments and suggestions..
--
This is an automated message from
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1068299715
### New Changes:
1. `addIndexes(CodecReader...)` merges are abortable now.
* Earlier, `addIndexes(CodecReader...)` triggered merges directly via
SegmentMerger. As a
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1062441177
Thanks for reviewing this @mikemccand ! I've addressed the ones that had
minor changes, and am working on the larger ones.
> What remains to bring this out of WIP?
vigyasharma commented on pull request #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1036989788
The `addIndexes(CodecReaders[])` API is transactional in nature - either all
readers get added or all of them fail. Retaining this behavior with concurrent
background merges n
