[GitHub] [lucene] zacharymorn commented on pull request #588: LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation (9.1.0 Backporting)

2022-01-30 Thread GitBox
zacharymorn commented on pull request #588: URL: https://github.com/apache/lucene/pull/588#issuecomment-1025447673 > > Maybe the best strategy here would be to keep the change entry for whichever version that goes out first (I think it will be 9.0.1? ), and for the other one we can skip th

[GitHub] [lucene] zacharymorn commented on pull request #588: LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation (9.1.0 Backporting)

2022-01-11 Thread GitBox
zacharymorn commented on pull request #588: URL: https://github.com/apache/lucene/pull/588#issuecomment-1010702372 Thanks @jtibshirani for the suggestions here! I have a few follow-up questions: > @zacharymorn here's my understanding of our usual strategy: on every branch of the sam

[GitHub] [lucene] zacharymorn commented on pull request #588: LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation (9.1.0 Backporting)

2022-01-06 Thread GitBox
zacharymorn commented on pull request #588: URL: https://github.com/apache/lucene/pull/588#issuecomment-1007166802 > The CHANGES file is supposed to have a JIRA issue under the earlier version that has this change. For instance if you merge something today that gets backported to 9.1, it s

[GitHub] [lucene] zacharymorn commented on pull request #588: LUCENE-10236: Update field-weight used in CombinedFieldQuery scoring calculation (9.1.0 Backporting)

2022-01-06 Thread GitBox
zacharymorn commented on pull request #588: URL: https://github.com/apache/lucene/pull/588#issuecomment-1006663802 > Feel free to merge this if tests pass and you didn't have to make significant changes upon backporting. Do we also need to move the CHANGES entry to a different version on o