zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-998323463
Thank you @rmuir and @mikemccand for reviewing this big PR! I'll merge it
myself :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-998225878
OK @rmuir some new commits are ready to be reviewed! Please take your time :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-985053769
@rmuir I've done the benchmark! (Sorry for the delay): and result looks
plain (which is good for this change)
```
TaskQPS base StdDevQPS cand
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-982125853
Thanks @rmuir, I'll run a benchmark to ensure this PR does not introduce
regression recently.
I like the approach you proposed in #485, it would be nice if we can get rid
of `
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-942835409
Thanks @dweiss seems this is not the first time we see this error:
https://issues.apache.org/jira/browse/LUCENE-9839
--
This is an automated message from the Apache Git Service.
To
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941199775
Hmmm one of the test failed
```
ERROR: The following test(s) have failed:
> Task :lucene:analysis:smartcn:test
- org.apache.lucene.index.TestIndexFileDeleter.testExcInDec
zhaih commented on pull request #225:
URL: https://github.com/apache/lucene/pull/225#issuecomment-941199775
Hmmm one of the test failed
```
ERROR: The following test(s) have failed:
> Task :lucene:analysis:smartcn:test
- org.apache.lucene.index.TestIndexFileDeleter.testExcInDec
