[GitHub] [lucene-solr] anshumg commented on pull request #2648: Widen version.base acceptance criteria to allow x.y.z.a (4 parts) format

2022-03-18 Thread GitBox
anshumg commented on pull request #2648: URL: https://github.com/apache/lucene-solr/pull/2648#issuecomment-1072832459 @uschindler - the restriction now is to comply w/ the pattern that looks like `baseVersion-suffix` i.e. have a `-` in the middle. Do you think removing the requireme

[GitHub] [lucene-solr] anshumg commented on pull request #2648: Widen version.base acceptance criteria to allow x.y.z.a (4 parts) format

2022-03-18 Thread GitBox
anshumg commented on pull request #2648: URL: https://github.com/apache/lucene-solr/pull/2648#issuecomment-1072777343 @uschindler - considering we already support `.1` and `.2` as the 4th part, I think it makes sense to remove that check unless there's a reason why only those 2 values sho

[GitHub] [lucene-solr] anshumg commented on pull request #2648: Widen version.base acceptance criteria to allow x.y.z.a (4 parts) format

2022-03-18 Thread GitBox
anshumg commented on pull request #2648: URL: https://github.com/apache/lucene-solr/pull/2648#issuecomment-1072754453 Will also create corresponding PR(s) for Lucene and Solr repos if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please lo