[GitHub] [lucene-solr] anshumg commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format

2022-05-31 Thread GitBox
anshumg commented on PR #2649: URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1142343899 Sorry, missed the mention. After thinking about this enough, I'm not comfortable merging this in - thanks to everyone who reviewed and also got me to rethink my approach :) -

[GitHub] [lucene-solr] anshumg commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format

2022-03-21 Thread GitBox
anshumg commented on pull request #2649: URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1074345569 Thanks for your suggestion @uschindler. I like your suggestion but can't think of a clean way to make this work for multiple internal releases. I'm trying to avoid forking

[GitHub] [lucene-solr] anshumg commented on pull request #2649: Remove '-' between base.version and version.suffix and change common-build to allow the new format

2022-03-18 Thread GitBox
anshumg commented on pull request #2649: URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1072869336 My concern here is for people who have scripts assuming the presence of `-` automatically. This might break back-compat for those folks. -- This is an automated message f