[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-22 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318 > @arafalov > There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696402318 > @arafalov > There is one already which I have modified(DistributedTermsComponentTest) - https://github.com/apache/lucene-solr/pull/1900/files#diff-9b9ccbcf271c6320902d

[GitHub] [lucene-solr] arafalov commented on pull request #1900: SOLR-14036: Remove explicit distrib=false from /terms handler

2020-09-21 Thread GitBox
arafalov commented on pull request #1900: URL: https://github.com/apache/lucene-solr/pull/1900#issuecomment-696269537 I can't comment on the code, as I did not understand the shard part. I am happy if the extra parameter (distrib=false) is not needed. I did feel that maybe a test was missi