atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-594654890
@dsmiley Updated, please see and let me know your thoughts and comments. I
have not added CHANGES.txt entry to
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-594352993
> OH; an idea occurred to me. We don't actually need the cost to be mutable
(which wasn't so pretty), we just
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-594318472
@dsmiley Any thoughts on this one?
This is an
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-594105306
> Ehh; nevermind my ill-thought-out idea of a cost on the Map context. There
are many ValueSource.getValues
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593544138
> Lets add the following test to TestFunctionRangeQuery:
>
> ```
> @Test
> public void
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593133186
@dsmiley Thinking further, I see no obvious way of ValueSourceScorer being
able to determine a reasonable cost
atris commented on issue #1303: LUCENE-9114: Improve ValueSourceScorer's
Default Cost Implementation
URL: https://github.com/apache/lucene-solr/pull/1303#issuecomment-593126930
> Wouldn't this result in an infinite loop?
The idea was that the underlying TwoPhaseIterator