chenkovsky commented on issue #895: fix LUCENE-8985
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-540876601
I have changed the code, and enabled the capture num test. now the capture
behavior is same as the original implementation. actually no performance impact.
---
chenkovsky commented on issue #895: fix LUCENE-8985
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539922291
@janhoy I have submitted the code, and passed all testcases. A small
difference compared to original implementation is that I will capture all
tokens(original impl
chenkovsky commented on issue #895: fix LUCENE-8985
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539368862
@janhoy I have fixed the bug. but I cannot pass some test. I think some test
cases are inconsistent.
in test testBasicKeepOrigTwoOutputs,
`
assertAnal
chenkovsky commented on issue #895: fix LUCENE-8985
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-534363981
@janhoy yes.
This is an automated message from the Apache Git Service.
To respond to the message,
chenkovsky commented on issue #895: fix LUCENE-8985
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-533858548
wait a minute, I add more testcases. It seems my patch is not correct now.
This is an automated mes
