[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-05 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773471401 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-05 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773883764 It's already merged :) This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-04 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773580816 Checking against available dictionaries looks like a good idea! This is an automated message from the Ap

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-04 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773501527 Will this buffer help even if these flags occur at the 37th MB? :) The mentioned dictionary is in the wooorm collection: https://github.com/wooorm/dictionaries/tre

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-04 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-773471401 As for this: ``` // TODO: can these flags change throughout the file? If not then we can abort sooner. And // then we wouldn't even need to create a

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771711060 Thank you, LGTM! This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [lucene-solr] donnerpeter commented on pull request #2277: LUCENE-9716: Hunspell: support flag usage before its format is even specified

2021-02-02 Thread GitBox
donnerpeter commented on pull request #2277: URL: https://github.com/apache/lucene-solr/pull/2277#issuecomment-771711060 Thank you, LGTM! This is an automated message from the Apache Git Service. To respond to the message, pl