[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-09-30 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-701351121 @jimczi I dunno if you want to look at this again but I plan to commit within the next day for 8.7. This

[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-09-21 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-696351031 Sorry for the delay; I have had a solution for over a month locally but didn't share it yet. I'm pretty comfortable with what I just pushed. I did some "fuzz

[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-09-21 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-696351031 Sorry for the delay; I have had a solution for over a month locally but didn't share it yet. I'm pretty comfortable with what I just pushed. I did some "fuzz

[GitHub] [lucene-solr] dsmiley commented on pull request #1740: LUCENE-9458: WDGF and WDF should tie-break by endOffset

2020-08-13 Thread GitBox
dsmiley commented on pull request #1740: URL: https://github.com/apache/lucene-solr/pull/1740#issuecomment-673640254 > I wonder if this is something that we should enforce somewhere. It seems that you only want the original term to come first so maybe we can mark it with a special flag ?