dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571936438
> Are we buffering output in both PrefixWriter and SpillWriter? Why do we
need to do that in two places?
To distinguish between s
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571780734
I just pushed a version which has the output handler precompiled as Java
code (faster than groovy) and does output spilling into task's
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571757656
> I'm a little confused what the motivation for the requirement to print
test output on failure comes from.
There are a few reas
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571727306
Hi Mike. I have a version working too -- seems like we've been working on
this concurrently. Let me polish the remaining bit and I'll po
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-571487783
Thanks. I'll try to combine what you did with what folks at ES did and have
something workable. It is important to get it right as peopl
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570798426
Yes, it works. Low level jvm messages or debugging security, network, etc,
screw it up badly though. But tests work.
--
dweiss commented on issue #1138: LUCENE-9077 Print repro line for failed tests
URL: https://github.com/apache/lucene-solr/pull/1138#issuecomment-570797460
Hi Mike. I looked at gradle's internal APIs again and I don't think we'll be
able to dodge having a custom test output listener. I would
