janhoy commented on issue #860: SOLR-13734 JWTAuthPlugin to support multiple issuers URL: https://github.com/apache/lucene-solr/pull/860#issuecomment-531881327 > When JIRAs have github PR's what's the appropriate place for higher-level, non-line-specific review comments? Is there a consensus on this? Is one more discoverable than the other? Good question. I'd hope we could move totally to GitHub issues+pr and scrap JIRA. But for now my thought is that if it is a big PR that will attract much comments in GitHub perhaps it is best to keep general comments in the PR as well, to keep all in one place, and then update the JIRA once in a while with general progress, i.e. (planning to merge in 3 days) to attract more attention. Thanks for your review. See JIRA for comments :) > Would it be possible to deprecate iss, wellKnownUrl etc outside of the issuers hash in this PR? I'll wait until both the "REST API issuers support" and "Admin UI choose issuer to log in with" are solved, so deprecation will not happen in this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
