[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985

2019-09-23 Thread GitBox
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-534189327 Waiting for you to update the PR with more test cases, is that correct @chenkovsky ? This is an automa

[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985

2019-10-07 Thread GitBox
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539152280 Would like to get this into 8.3, and release process starts in one week. @chenkovsky, do you have time to wrap it up? -

[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985

2019-10-07 Thread GitBox
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539152601 Also, please add an entry in lucene/CHANGES.txt to this PR This is an automated message from the Apache

[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985

2019-10-07 Thread GitBox
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-539153980 @mikemccand or @msokolov are you available for quick review? This is an automated message from the Apac

[GitHub] [lucene-solr] janhoy commented on issue #895: fix LUCENE-8985

2019-10-10 Thread GitBox
janhoy commented on issue #895: fix LUCENE-8985 URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-540814515 Hmm, your commit 867cbeff010ff0febbbd258368a58ddecc770b93 labeled "bug fix" is changing a ton of code and changing this PR from a quite simple low-risk patch into a mo