limingnihao opened a new pull request #1693:
URL: https://github.com/apache/lucene-solr/pull/1693


   …on with no result
   
   <!--
   _(If you are a project committer then you may remove some/all of the 
following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system 
for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people 
scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly 
updated with code review comments and commits. -->
   
   
   # Description
   When TimeAllowed is set, the SolrQueryTimeoutImpl function will be started 
to detect whether it has timed out when the term is loaded. When overtime, an 
ExitingReaderException is thrown.
   In the process of scoreFeatures of LTRQuery, ExitingReaderException will 
occur in two stages.
1.scorer. Occurs when a term needs to be loaded to the 
LeafReaderContext when creating Weight.
2.score. The term needs to be loaded 
when some functions call getValue. For example, FloatPayloadValueSource.
   So it can be compatible with this ExitingReaderException, and partly return. 
More empty results are better.
   
   # Solution
   1. In the scorer process, catch ExitingReaderException and return the 
currently loaded document.
   2. In the score process, catch ExitingReaderException and return the 
currently calculated document.
   
   # Tests
   Simulation throws ExitingReaderException in the scorer process, and 
partially returns the loaded document.
Simulation throws ExitingReaderException 
in the score process of Feature, partially returning the calculated document.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [x] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to