[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-08 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r484953808 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -290,5 +299,114 @@ public void testF

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-08 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r484953402 ## File path: lucene/core/src/test/org/apache/lucene/search/TestFieldSortOptimizationSkipping.java ## @@ -290,5 +299,114 @@ public void testF

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-02 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r482105620 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-02 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r482105620 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-01 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r481443544 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-01 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r481441664 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,183 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-09-01 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r481011126 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-31 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r480386087 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-26 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477509287 ## File path: lucene/core/src/java/org/apache/lucene/search/comparators/DocComparator.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apach

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-26 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504436 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ## @@ -150,11 +150,15 @@ public void setScorer(Scorable sco

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-26 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504337 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringLeafFieldComparator.java ## @@ -32,8 +33,22 @@ DocIdSetIterator compe

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-26 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r477504147 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldComparator.java ## @@ -136,6 +136,13 @@ public int compareValues(T first, T s

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469568119 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringDocLeafComparator.java ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apac

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469566632 ## File path: lucene/core/src/java/org/apache/lucene/search/FieldValueHitQueue.java ## @@ -121,7 +121,7 @@ protected boolean lessThan(final En

[GitHub] [lucene-solr] mayya-sharipova commented on a change in pull request #1725: LUCENE-9449 Skip docs with _doc sort and "after"

2020-08-12 Thread GitBox
mayya-sharipova commented on a change in pull request #1725: URL: https://github.com/apache/lucene-solr/pull/1725#discussion_r469565524 ## File path: lucene/core/src/java/org/apache/lucene/search/FilteringFieldComparator.java ## @@ -68,10 +68,12 @@ public int compareValues(T f