mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-770069329
Thanks @cammiemw!
One thing I noticed after I pushed was the new `Scorable.smothingScore(int
docId)` method: why does this take the `int docId` parameter? Shouldn'
mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-770011220
Thanks @cammiemw, that test now passes again!
I ran top-level tests multiple times and each time, a solr test failed for
what looked like (not certain) unrelated to
mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-768299026
Hello @cammiemw, I ran top-level `./gradlew test` on the latest diff here,
yet still see the Solr `TestFeature` failure:
```
org.apache.solr.ltr.feature.TestFeat
mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-767646296
> I have added an entry in CHANGES.txt under API changes.
Thank you!
I ran top-level `./gradlew test` with this change but hit this Solr test
failure, caused
mikemccand commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-758675804
Thank you @cammiemw!
Looks like there are some small style problems with your PR -- see the above
`Gradle precommit` for details. We now enforce consistent styling
