[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-14 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r334571275 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointInPolygonQuery.java ## @@ -133,28 +133,25

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r332617735 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointInPolygonQuery.java ## @@ -84,7 +84,7 @@

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r333707304 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -34,232 +31,123 @@ * practical lines

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r333706202 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -269,138 +157,109 @@ boolean

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r332617337 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointInPolygonQuery.java ## @@ -84,7 +84,7 @@

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r332623926 ## File path: lucene/core/src/java/org/apache/lucene/geo/Component2D.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r333706728 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -269,138 +157,109 @@ boolean

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r333707413 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -34,232 +31,123 @@ * practical lines

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r332618228 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointInPolygonQuery.java ## @@ -133,28 +133,25

[GitHub] [lucene-solr] nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree

2019-10-10 Thread GitBox
nknize commented on a change in pull request #878: LUCENE-8746: Refactor EdgeTree URL: https://github.com/apache/lucene-solr/pull/878#discussion_r332625152 ## File path: lucene/core/src/java/org/apache/lucene/geo/EdgeTree.java ## @@ -34,232 +31,123 @@ * practical lines