[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-15 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r455476821 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -191,6 +191,11 @@ private String name; private String logid; // us

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-15 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454854570 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -188,6 +190,7 @@ public IndexSchema(String name, InputSource is, Vers

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-15 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454855401 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -752,6 +765,9 @@ public void close() throws IOException { }

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-15 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454854570 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -188,6 +190,7 @@ public IndexSchema(String name, InputSource is, Vers

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-15 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454850576 ## File path: solr/core/src/java/org/apache/solr/pkg/MultiPackageListener.java ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454704926 ## File path: solr/core/src/java/org/apache/solr/schema/IndexSchema.java ## @@ -188,6 +190,7 @@ public IndexSchema(String name, InputSource is, Vers

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454702783 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -198,6 +206,11 @@ synchronized void reloadLuceneSPI() { Tok

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454702702 ## File path: solr/core/src/java/org/apache/solr/core/SolrCore.java ## @@ -191,6 +191,11 @@ private String name; private String logid; // us

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454701342 ## File path: solr/core/src/java/org/apache/solr/pkg/PackageListeners.java ## @@ -96,15 +97,42 @@ private synchronized void invokeListeners(Package

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454700983 ## File path: solr/core/src/java/org/apache/solr/handler/StreamHandler.java ## @@ -158,8 +158,8 @@ public Class getClazz() { } @Override

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1669: SOLR-14151 Make schema components load from packages

2020-07-14 Thread GitBox
noblepaul commented on a change in pull request #1669: URL: https://github.com/apache/lucene-solr/pull/1669#discussion_r454700567 ## File path: solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java ## @@ -752,6 +765,9 @@ public void close() throws IOException { }