noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420028
Here is an example of how to have strong typing for each atribute without
creating so many different interfaces
`public interface PropertyFetcher {`
`PropertyF
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683420148
So, I have two main problems with this PR
1. Using `solr.xml`
2. having 2 interfaces for each property
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683488170
>There's no other place to set default config (not hard code!) for which
placement plugin to use
What is wrong with hard coding?
-
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683772488
> the way forward should be to maybe use Solr.XML only
for now to unblock you, but revisit it later to leverage clusterprops
before the release. @noble, is that okay f
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683771821
>I’d be happy to change the current proposal for something easier to use
(not pretending it’s perfect) but I’m not willing to sacrifice on performance
in order to do so.
noblepaul commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-683778043
Let us take a step back and reassess at what we have today.
https://github.com/apache/lucene-solr/blob/4a2a2da462ef017154856edd92b9f4f8c549c084/solr/core/src/java/or
