[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r40656 ## File path: lucene/core/src/java/org/apache/lucene/search/LeafCollector.java ## @@

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-15 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r408887800 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@ -24,

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-13 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r407526518 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-13 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r407527282 ## File path: lucene/test-framework/src/java/org/apache/lucene/search/AssertingLeafCollector.j

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-13 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r407525287 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-13 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r407524764 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@ -24,

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-13 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r407523929 ## File path: lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java ###

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-09 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r406054398 ## File path: lucene/core/src/java/org/apache/lucene/search/ScoreMode.java ## @@ -51,

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-09 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r406053016 ## File path: lucene/core/src/test/org/apache/lucene/search/TestSortOptimization.java ###

[GitHub] [lucene-solr] romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents

2020-04-09 Thread GitBox
romseygeek commented on a change in pull request #1351: LUCENE-9280: Collectors to skip noncompetitive documents URL: https://github.com/apache/lucene-solr/pull/1351#discussion_r406046648 ## File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java ##