shalinmangar commented on pull request #1647: URL: https://github.com/apache/lucene-solr/pull/1647#issuecomment-653714746
Please be specific about the changes. Why do you think preClose is unnecessary? I see that invocation of `removeEphemeralLiveNode` method is removed entirely. Why do you think that is a safe change to make? With this PR, the live node is not removed until the zk client is closed which happens after pretty much everything is closed. This will cause other clients/replicas to keep sending requests to this node and erroring out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
