[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554052572 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DrillStream.java ## @@ -252,29 +253,27 @@ public void setStreamContext(St

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554056609 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/metrics/MaxMetric.java ## @@ -86,7 +86,7 @@ public void update(Tuple tupl

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554055360 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -842,10 +881,99 @@ public int getCost() { @Ov

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054810 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -537,14 +555,29 @@ public void setStreamContext(St

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554054274 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/FacetStream.java ## @@ -20,15 +20,19 @@ import java.util.ArrayList; imp

[GitHub] [lucene-solr] thelabdude commented on a change in pull request #2132: SOLR-15036: auto- select / rollup / sort / plist over facet expression when using a collection alias with multiple collec

thelabdude commented on a change in pull request #2132: URL: https://github.com/apache/lucene-solr/pull/2132#discussion_r554052572 ## File path: solr/solrj/src/java/org/apache/solr/client/solrj/io/stream/DrillStream.java ## @@ -252,29 +253,27 @@ public void setStreamContext(St