[GitHub] [lucene-solr] vonbox commented on a change in pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-11 Thread GitBox
vonbox commented on a change in pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#discussion_r541134314 ## File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java ## @@ -361,7 +361,9 @@ protected ValueSource parseValueSource(int flags) t

[GitHub] [lucene-solr] vonbox commented on a change in pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-09 Thread GitBox
vonbox commented on a change in pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#discussion_r539142484 ## File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java ## @@ -361,7 +361,9 @@ protected ValueSource parseValueSource(int flags) t

[GitHub] [lucene-solr] vonbox commented on a change in pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-09 Thread GitBox
vonbox commented on a change in pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118#discussion_r539086072 ## File path: solr/core/src/java/org/apache/solr/search/FunctionQParser.java ## @@ -361,7 +361,9 @@ protected ValueSource parseValueSource(int flags) t