[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483794345 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483720288 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483719049 ## File path: lucene/core/src/java/org/apache/lucene/analysis/CharArrayMap.java ## @@ -523,6 +523,7 @@ public void clear() { * @throws NullPointe

[GitHub] [lucene-solr] vthacker commented on a change in pull request #1828: LUCENE-9497: add google error prone checks

2020-09-04 Thread GitBox
vthacker commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483717480 ## File path: gradle/validation/error-prone.gradle ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +