[GitHub] [lucene-solr] xiaoshi2013 commented on pull request #2566: LUCENE-10091 Fix some old errors in the benchmark module

2021-09-09 Thread GitBox
xiaoshi2013 commented on pull request #2566: URL: https://github.com/apache/lucene-solr/pull/2566#issuecomment-916265920 > Thanks @xiaoshi2013 -- looks great. I'll try to push soon. Could you also open a PR against Lucene's mainline (`lucene` GitHub repository)? Of course, soon. --

[GitHub] [lucene-solr] xiaoshi2013 commented on pull request #2566: LUCENE-10091 Fix some old errors in the benchmark module

2021-09-09 Thread GitBox
xiaoshi2013 commented on pull request #2566: URL: https://github.com/apache/lucene-solr/pull/2566#issuecomment-916245690 Excuse me @mikemccand, please review when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [lucene-solr] xiaoshi2013 commented on pull request #2566: LUCENE-10091 Fix some old errors in the benchmark module

2021-09-08 Thread GitBox
xiaoshi2013 commented on pull request #2566: URL: https://github.com/apache/lucene-solr/pull/2566#issuecomment-915296398 Thanks @mikemccand , request you a review of my pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and