Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-03-07 Thread via GitHub
angadp commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1985113703 Sorry for the late reply! I think my initial thinking was wrong. I'm currently implementing this and will post the code along with the benchmarks by next week. -- This is

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-02-01 Thread via GitHub
benwtrent commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1921160057 > What was the decision behind adding these candidates `outOfOrder`? Speed, once we know things are sorted, we know they have been checked for diversity. But with any

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-01-31 Thread via GitHub
angadp commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1920390020 I see what you were saying earlier now, Ben! So when we add the candidate we add them using `outOfOrder` method which is non-montonic and then try to find the least diverse

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-01-09 Thread via GitHub
angadp commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1883522255 Thanks! I was looking for an open issue and will check this out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-01-09 Thread via GitHub
benwtrent commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1883500270 @angadp I think it's more relevant given recent refactors. A radix heap may be possible now. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Explore moving HNSW's NeighborQueue to a radix heap [LUCENE-10383] [lucene]

2024-01-09 Thread via GitHub
angadp commented on issue #11419: URL: https://github.com/apache/lucene/issues/11419#issuecomment-1883368469 Given the comment by @benwtrent is this issue still relevant? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and