[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464587#comment-17464587 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-23 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464514#comment-17464514 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-23 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17464394#comment-17464394 ] Tomoko Uchida commented on LUCENE-10301: The test-framework module has several

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463750#comment-17463750 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463749#comment-17463749 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-22 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463706#comment-17463706 ] Uwe Schindler commented on LUCENE-10301: Hi, I created a PR with some followup

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463456#comment-17463456 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463446#comment-17463446 ] Dawid Weiss commented on LUCENE-10301: -- Backport PR: [https://github.com/apache/lu

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463434#comment-17463434 ] ASF subversion and git services commented on LUCENE-10301: -- Co

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463331#comment-17463331 ] Uwe Schindler commented on LUCENE-10301: bq. I really do think this is sufficie

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463292#comment-17463292 ] Dawid Weiss commented on LUCENE-10301: -- I'll add a placeholder empty method for th

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463281#comment-17463281 ] Dawid Weiss commented on LUCENE-10301: -- {quote}calls our setters from outside the

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-21 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463277#comment-17463277 ] Uwe Schindler commented on LUCENE-10301: Hi, I made my comments on the PR, we s

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462655#comment-17462655 ] Dawid Weiss commented on LUCENE-10301: -- I think this went rather ok. I've moved al

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462301#comment-17462301 ] Dawid Weiss commented on LUCENE-10301: -- [https://github.com/apache/lucene/pull/551

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-19 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17462167#comment-17462167 ] Dawid Weiss commented on LUCENE-10301: -- I started playing by just moving stuff. St

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456540#comment-17456540 ] Dawid Weiss commented on LUCENE-10301: -- I'm really not sure... but I anticipate pr

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456468#comment-17456468 ] Robert Muir commented on LUCENE-10301: -- Can someone propose a new package name to

[jira] [Commented] (LUCENE-10301) The test-framework as a module (or a separate test-framework-module)

2021-12-09 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456466#comment-17456466 ] Robert Muir commented on LUCENE-10301: -- I imagine the refactoring would be very no