[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-07-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154886#comment-17154886 ] ASF subversion and git services commented on LUCENE-8574: - Commi

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-07-09 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17154878#comment-17154878 ] ASF subversion and git services commented on LUCENE-8574: - Commi

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-07-06 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152272#comment-17152272 ] Michael McCandless commented on LUCENE-8574: Thanks [~zhai7631], the PR look

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-07-06 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152178#comment-17152178 ] Michael McCandless commented on LUCENE-8574: Thanks [~zhai7631] I like that

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-07-01 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149623#comment-17149623 ] Haoyu Zhai commented on LUCENE-8574: [~mikemccand] Yes it fixes the test case. Befor

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-30 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148963#comment-17148963 ] Michael McCandless commented on LUCENE-8574: [~zhai7631] does this fix your

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-25 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17145732#comment-17145732 ] Haoyu Zhai commented on LUCENE-8574: Made a PR([https://github.com/apache/lucene-sol

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-18 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139437#comment-17139437 ] Michael McCandless commented on LUCENE-8574: {quote}please, lets keep the bo

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-17 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138710#comment-17138710 ] Haoyu Zhai commented on LUCENE-8574: Ah, yes will use boolean instead of NaN. I'm ju

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138277#comment-17138277 ] Robert Muir commented on LUCENE-8574: - please, lets keep the boolean and not bring N

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-16 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137920#comment-17137920 ] Haoyu Zhai commented on LUCENE-8574: I've attached a unit test showing a case that c

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-15 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136136#comment-17136136 ] Haoyu Zhai commented on LUCENE-8574: I've checked the current release and couldn't s

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-12 Thread Haoyu Zhai (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134323#comment-17134323 ] Haoyu Zhai commented on LUCENE-8574: Sry, wrong commit message pointed to here, the

[jira] [Commented] (LUCENE-8574) ExpressionFunctionValues should cache per-hit value

2020-06-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133940#comment-17133940 ] ASF subversion and git services commented on LUCENE-8574: - Commi