[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251038#comment-17251038
]
Dawid Weiss commented on LUCENE-9564:
-
I've added the infrastructure and will progre
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251037#comment-17251037
]
ASF subversion and git services commented on LUCENE-9564:
-
Commi
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247738#comment-17247738
]
Dawid Weiss commented on LUCENE-9564:
-
I'm sorry - I remember about this but didn't
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247684#comment-17247684
]
Houston Putman commented on LUCENE-9564:
+1, I think this is a terrific idea!
G
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17247581#comment-17247581
]
Erick Erickson commented on LUCENE-9564:
I've been in 2-hour meetings early in m
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209743#comment-17209743
]
Dawid Weiss commented on LUCENE-9564:
-
Interesting. I'm sure it does contain some b
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209741#comment-17209741
]
David Smiley commented on LUCENE-9564:
--
+1 -- bold move, and I'm in favor!
Big-bang
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209652#comment-17209652
]
Robert Muir commented on LUCENE-9564:
-
As far as the downsides, I know projects drop
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209603#comment-17209603
]
Dawid Weiss commented on LUCENE-9564:
-
The big difference is that checkstyle is conf
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209590#comment-17209590
]
Michael Sokolov commented on LUCENE-9564:
-
I would quibble with a few of its cho
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209325#comment-17209325
]
Dawid Weiss commented on LUCENE-9564:
-
Well, I expected more resistance. ;) And seri
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209223#comment-17209223
]
Erick Erickson commented on LUCENE-9564:
[~jpountz] I don't think you'll miss 2
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209193#comment-17209193
]
Robert Muir commented on LUCENE-9564:
-
+1 from my side too.
The current situation
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209146#comment-17209146
]
Adrien Grand commented on LUCENE-9564:
--
There are downsides to code formatting (I'l
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209025#comment-17209025
]
Dawid Weiss commented on LUCENE-9564:
-
Bull's eye! Thanks Robert. Interesting tool t
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209000#comment-17209000
]
Robert Muir commented on LUCENE-9564:
-
https://github.com/psf/black#migrating-your-c
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208845#comment-17208845
]
Dawid Weiss commented on LUCENE-9564:
-
Yes, you're correct. I don't know if there is
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208840#comment-17208840
]
Varun Thacker commented on LUCENE-9564:
---
+1 to consistent and enforced formatting.
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208763#comment-17208763
]
Dawid Weiss commented on LUCENE-9564:
-
Ideally, they should be wrapped in code block
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208739#comment-17208739
]
Erick Erickson commented on LUCENE-9564:
Ah, so you're saying that the bits I po
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208720#comment-17208720
]
Dawid Weiss commented on LUCENE-9564:
-
Google's style guide:
https://google.github.i
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208702#comment-17208702
]
Dawid Weiss commented on LUCENE-9564:
-
> I'd recommend it be as close to the current
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208679#comment-17208679
]
Erick Erickson commented on LUCENE-9564:
+1 I can adapt to most any style more e
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208663#comment-17208663
]
Andrzej Bialecki commented on LUCENE-9564:
--
+1 to consistent and enforced forma
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208625#comment-17208625
]
Dawid Weiss commented on LUCENE-9564:
-
The check itself could run in precommit. A "c
[
https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208615#comment-17208615
]
Michael McCandless commented on LUCENE-9564:
+1 to achieve more consistent c
26 matches
Mail list logo
