[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-28 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17310164#comment-17310164 ] Uwe Schindler commented on LUCENE-9879: --- I think it's all fine. We can close this

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309717#comment-17309717 ] Dawid Weiss commented on LUCENE-9879: - I committed this in as it was, [~uschindler].

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309312#comment-17309312 ] Robert Muir commented on LUCENE-9879: - {quote} Thanks Robert: this explains why it g

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309264#comment-17309264 ] Uwe Schindler commented on LUCENE-9879: --- Yes. I think that's easiest to do without

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309259#comment-17309259 ] Dawid Weiss commented on LUCENE-9879: - We can add a separate flag too, of course ("b

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309256#comment-17309256 ] Uwe Schindler commented on LUCENE-9879: --- Option 3 seems fine, but maybe with a sep

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309239#comment-17309239 ] Dawid Weiss commented on LUCENE-9879: - Left a PR implementing option (3). > errorpr

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-26 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309237#comment-17309237 ] Dawid Weiss commented on LUCENE-9879: - Oh... so that's why it's slow! I see three o

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309138#comment-17309138 ] Robert Muir commented on LUCENE-9879: - Related issue, particularly this comment: ht

[jira] [Commented] (LUCENE-9879) errorprone cause large slowdown of compileJava/compileTestJava

2021-03-25 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17309136#comment-17309136 ] Robert Muir commented on LUCENE-9879: - In an ideal world I think, we'd let javac do