[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-20 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041399#comment-17041399 ] Mike Drob commented on SOLR-14274: -- I see that {{SolrMetricsManager.registerAll}} has a

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042129#comment-17042129 ] Mike Drob commented on SOLR-14274: -- The comment in {{SolrMetricManagerTest}}: {code}

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-21 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042136#comment-17042136 ] Andrzej Bialecki commented on SOLR-14274: - [~mdrob] yeah, that comment is wrong -

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042236#comment-17042236 ] Mike Drob commented on SOLR-14274: -- Looking at the metrics in SolrIndexSearcher, I wonde

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-24 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17043684#comment-17043684 ] Mike Drob commented on SOLR-14274: -- I think the behavior that we want varies with what k

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-26 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17046294#comment-17046294 ] Andrzej Bialecki commented on SOLR-14274: - {quote}I'm looking at this with replac

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-02-28 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047848#comment-17047848 ] Mike Drob commented on SOLR-14274: -- I put up a rough PR of what this might look like, le

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-03-05 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052427#comment-17052427 ] Mike Drob commented on SOLR-14274: -- [~ab] - gentle ping on this, would be interested to

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-03-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17066978#comment-17066978 ] ASF subversion and git services commented on SOLR-14274: Commit 8

[jira] [Commented] (SOLR-14274) Multiple CoreContainers will register the same JVM Metrics

2020-03-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17067191#comment-17067191 ] ASF subversion and git services commented on SOLR-14274: Commit f