[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226325#comment-17226325
]
Otis Gospodnetic commented on SOLR-14588:
-
Are these circuit breakers exposed as metrics so one
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217027#comment-17217027
]
Atri Sharma commented on SOLR-14588:
Thanks for catching it, David!
I backported the
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17217003#comment-17217003
]
David Smiley commented on SOLR-14588:
-
The backport forgot the package-info.json, and so precommit is
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215300#comment-17215300
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215301#comment-17215301
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210401#comment-17210401
]
Cassandra Targett commented on SOLR-14588:
--
[~atris], This issue is marked as fixed in 8.7, but
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190033#comment-17190033
]
Ishan Chattopadhyaya commented on SOLR-14588:
-
bq. Fixed configuration in
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175453#comment-17175453
]
Atri Sharma commented on SOLR-14588:
As discussed offline, this can be done as a refactor before 8.7
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175402#comment-17175402
]
Noble Paul commented on SOLR-14588:
---
The configuration can be as follows
{code:xml}
{code}
Nowhere
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175399#comment-17175399
]
Noble Paul commented on SOLR-14588:
---
Let's revert this and fix the configuration
> Circuit Breakers
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154897#comment-17154897
]
Atri Sharma commented on SOLR-14588:
I beasted the test under high CPU stress -- still could not
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154882#comment-17154882
]
Atri Sharma commented on SOLR-14588:
Thanks for highlighting -- I am taking a look. Can you please
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149998#comment-17149998
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1714#comment-1714
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148370#comment-17148370
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147892#comment-17147892
]
Erick Erickson commented on SOLR-14588:
---
Next time I do something like this I'll just @AwaitsFix
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147866#comment-17147866
]
Atri Sharma commented on SOLR-14588:
[~janhoy] Not at all. I am grateful for the effort that you took
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147675#comment-17147675
]
Jan Høydahl commented on SOLR-14588:
Master is still failing. There are remnants of circuit breaker
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147688#comment-17147688
]
Jan Høydahl commented on SOLR-14588:
NP - I decided to commit instead of wait, given the small size
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147681#comment-17147681
]
Atri Sharma commented on SOLR-14588:
Thanks [~janhoy], you beat me to it!
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147679#comment-17147679
]
Jan Høydahl commented on SOLR-14588:
Fixed in
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147410#comment-17147410
]
Atri Sharma commented on SOLR-14588:
[~ab] Not able to find your git ID hence couldnt tag you for
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147406#comment-17147406
]
Atri Sharma commented on SOLR-14588:
I have raised an updated PR -- please see and provide comments
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147046#comment-17147046
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147044#comment-17147044
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147045#comment-17147045
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147043#comment-17147043
]
Atri Sharma commented on SOLR-14588:
Ok, based on the discussion here, I am reverting this commit and
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147037#comment-17147037
]
Erick Erickson commented on SOLR-14588:
---
Even with more review, it should probably wait until the
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147035#comment-17147035
]
Andrzej Bialecki commented on SOLR-14588:
-
I agree. We need a much better analysis of the impact
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147027#comment-17147027
]
David Smiley commented on SOLR-14588:
-
I think a feature of this nature should get more peer review
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146601#comment-17146601
]
Andrzej Bialecki commented on SOLR-14588:
-
[~atris] Thanks for adding the javadocs and
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146486#comment-17146486
]
Atri Sharma commented on SOLR-14588:
[~erickerickson] Thank you so much for covering the test failure
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146481#comment-17146481
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146249#comment-17146249
]
Erick Erickson commented on SOLR-14588:
---
I should really have just disabled the test. I don't think
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146168#comment-17146168
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146174#comment-17146174
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145999#comment-17145999
]
Atri Sharma commented on SOLR-14588:
[~erickerickson] Thank you for proactively fixing the test!
Did
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145920#comment-17145920
]
Erick Erickson commented on SOLR-14588:
---
[~atris] This fixes the test by checking on the
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145919#comment-17145919
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145873#comment-17145873
]
Gus Heck commented on SOLR-14588:
-
[http://fucit.org/solr-jenkins-reports/failure-report.html] - failing
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145747#comment-17145747
]
Erick Erickson commented on SOLR-14588:
---
[~atris] I believe this is producing the following test
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145099#comment-17145099
]
Atri Sharma commented on SOLR-14588:
[~ab] Thanks for commenting. I will add documentation and update
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145066#comment-17145066
]
Andrzej Bialecki commented on SOLR-14588:
-
[~atris] please see the comment above - the title of
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145060#comment-17145060
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145057#comment-17145057
]
Atri Sharma commented on SOLR-14588:
[~mdrob] Yes, realised that post pushing. Pushing a fix now.
>
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145051#comment-17145051
]
Andrzej Bialecki commented on SOLR-14588:
-
I must have missed the discussion about the design of
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145039#comment-17145039
]
Mike Drob commented on SOLR-14588:
--
[~atris] - needs a CHANGES entry too
> Circuit Breakers
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145030#comment-17145030
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145029#comment-17145029
]
ASF subversion and git services commented on SOLR-14588:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143064#comment-17143064
]
Mike Drob commented on SOLR-14588:
--
See also SOLR-6930
> Circuit Breakers Infrastructure and Real JVM
50 matches
Mail list logo
