[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298146#comment-17298146
]
Andrzej Bialecki commented on SOLR-14749:
-
It looks like the underlying cause of the failures was
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298138#comment-17298138
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294211#comment-17294211
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14749:
--
[~dsmiley] brought up
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17229059#comment-17229059
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226705#comment-17226705
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226674#comment-17226674
]
Andrzej Bialecki commented on SOLR-14749:
-
Thanks [~noble.paul] and [~ilan] for comments and
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226657#comment-17226657
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1702#comment-1702
]
Andrzej Bialecki commented on SOLR-14749:
-
This is not strictly speaking a user-level
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221797#comment-17221797
]
Noble Paul commented on SOLR-14749:
---
I mean we have 2 new capabilities
* Registering a cluster
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221730#comment-17221730
]
Andrzej Bialecki commented on SOLR-14749:
-
[~noble.paul] "this" meaning what part specifically?
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221293#comment-17221293
]
Noble Paul commented on SOLR-14749:
---
[~ab], this is a user-facing change, Can you please add add
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218444#comment-17218444
]
ASF subversion and git services commented on SOLR-14749:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210168#comment-17210168
]
Noble Paul commented on SOLR-14749:
---
Thanks [~ab] . I shall review it soon
> Provide a clean API for
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210165#comment-17210165
]
Andrzej Bialecki commented on SOLR-14749:
-
[~noble.paul] PR-1964 contains just the
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210131#comment-17210131
]
Andrzej Bialecki commented on SOLR-14749:
-
[~noble.paul] please see PR-1962 that contains just
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206584#comment-17206584
]
Noble Paul commented on SOLR-14749:
---
{quote}I had the impression we are having a proper discussion,
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17206361#comment-17206361
]
Andrzej Bialecki commented on SOLR-14749:
-
{quote}The PR is too complex.
{quote}
What part is too
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205388#comment-17205388
]
Ishan Chattopadhyaya commented on SOLR-14749:
-
bq. I would like to see a separate PR for
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205364#comment-17205364
]
Noble Paul commented on SOLR-14749:
---
Here is my official -1 on this PR
> Provide a clean API for
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204769#comment-17204769
]
Noble Paul commented on SOLR-14749:
---
[~ab] please do not make backward incompatible changes without
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201299#comment-17201299
]
Noble Paul commented on SOLR-14749:
---
The PR is too complex.
I would like to see a separate PR for
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192974#comment-17192974
]
Ishan Chattopadhyaya commented on SOLR-14749:
-
I'd prefer if this were to be completely
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192921#comment-17192921
]
Andrzej Bialecki commented on SOLR-14749:
-
[~ichattopadhyaya] as I explained in the comments that
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180444#comment-17180444
]
Ishan Chattopadhyaya commented on SOLR-14749:
-
I've mentioned it in this comment in the PR,
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17179145#comment-17179145
]
Andrzej Bialecki commented on SOLR-14749:
-
See [https://github.com/apache/lucene-solr/pull/1758]
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177739#comment-17177739
]
Andrzej Bialecki commented on SOLR-14749:
-
{quote}If a plugin wishes to listen to a ZK node
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177290#comment-17177290
]
Ilan Ginzburg commented on SOLR-14749:
--
Not all plugins need to execute on one designated node. Most
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177221#comment-17177221
]
Ilan Ginzburg commented on SOLR-14749:
--
if there’s an abstraction layer between Solr and
[
https://issues.apache.org/jira/browse/SOLR-14749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17177029#comment-17177029
]
Noble Paul commented on SOLR-14749:
---
In general my suggestions are as foloows.
* we should only have
29 matches
Mail list logo
