[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-03-09 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298116#comment-17298116 ] Andrzej Bialecki commented on SOLR-15122: - [~mdrob] I think we can close this, the changes that

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278465#comment-17278465 ] Mike Drob commented on SOLR-15122: -- Thanks to [~ab] for identifying where he suspected the issue was,

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-03 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278462#comment-17278462 ] ASF subversion and git services commented on SOLR-15122: Commit

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-03 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278333#comment-17278333 ] Mike Drob commented on SOLR-15122: -- If we're not building our own concurrency logic, then I think it's

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277529#comment-17277529 ] Ilan Ginzburg commented on SOLR-15122: -- I've never used this specific class but if you make it so

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277519#comment-17277519 ] Mike Drob commented on SOLR-15122: -- I was thinking about this some more, and think we should use a

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277448#comment-17277448 ] Ilan Ginzburg commented on SOLR-15122: -- Added a few comments. I like this approach much better.

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277423#comment-17277423 ] Mike Drob commented on SOLR-15122: -- Refactored the code in anticipation of working over

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277406#comment-17277406 ] Ilan Ginzburg commented on SOLR-15122: -- You're right about no mutable Integer. Would there be a way

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277399#comment-17277399 ] Mike Drob commented on SOLR-15122: -- I'm pretty comfortable with that blanket statement. If you're using

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Ilan Ginzburg (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277360#comment-17277360 ] Ilan Ginzburg commented on SOLR-15122: -- ??We shouldn't use postfix increment with a volatile

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277353#comment-17277353 ] Mike Drob commented on SOLR-15122: -- I put up a PR to demonstrate what I meant, I think the same pattern

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277129#comment-17277129 ] Mike Drob commented on SOLR-15122: -- I had just gone through and replaced a bunch of busy wait loops with

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277044#comment-17277044 ] Andrzej Bialecki commented on SOLR-15122: - I'll leave this open to see if the fix works. >

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277041#comment-17277041 ] ASF subversion and git services commented on SOLR-15122: Commit

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-02-01 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276255#comment-17276255 ] Andrzej Bialecki commented on SOLR-15122: - Hmm. I suspect this is caused by the plugin config

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-01-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275380#comment-17275380 ] ASF subversion and git services commented on SOLR-15122: Commit

[jira] [Commented] (SOLR-15122) ClusterEventProducerTest.testEvents is unstable

2021-01-29 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275377#comment-17275377 ] Mike Drob commented on SOLR-15122: -- [~ab] - looks like this has been flaky since is was introduced in