[ 
https://issues.apache.org/jira/browse/SOLR-13264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrzej Bialecki resolved SOLR-13264.
-------------------------------------
    Resolution: Fixed

Thanks Christine!

Christof: this didn't make it to 8.5, which is now being released, but it will 
be available in 8.6. The change is straightforward so it should be easy to 
apply this to 7x.

> IndexSizeTrigger aboveOp / belowOp properties not in valid properties
> ---------------------------------------------------------------------
>
>                 Key: SOLR-13264
>                 URL: https://issues.apache.org/jira/browse/SOLR-13264
>             Project: Solr
>          Issue Type: Bug
>          Components: AutoScaling
>            Reporter: Christine Poerschke
>            Assignee: Andrzej Bialecki
>            Priority: Minor
>             Fix For: 8.6
>
>         Attachments: SOLR-13264.patch, SOLR-13264.patch
>
>
> Steps to reproduce:
> {code}
> ./bin/solr start -cloud -noprompt
> ./bin/solr create -c demo -d _default -shards 1 -replicationFactor 1
> curl "http://localhost:8983/solr/admin/autoscaling"; -d'
> {
>   "set-trigger" : {
>     "name" : "index_size_trigger",
>     "event" : "indexSize",
>     "aboveDocs" : 12345,
>     "aboveOp" : "SPLITSHARD",
>     "enabled" : true,
>     "actions" : [
>       {
>         "name" : "compute_plan",
>         "class": "solr.ComputePlanAction"
>       }
>     ]
>   }
> }
> '
> ./bin/solr stop -all
> {code}
> The {{aboveOp}} is documented on 
> https://lucene.apache.org/solr/guide/7_6/solrcloud-autoscaling-triggers.html#index-size-trigger
>  and logically should be accepted (even though it is actually the default) 
> but unexpectedly an error message is returned {{"Error validating trigger 
> config index_size_trigger: 
> TriggerValidationException\{name=index_size_trigger, 
> details='\{aboveOp=unknown property\}'\}"}}.
> From a quick look it seems that in the {{IndexSizeTrigger}} constructor 
> additional values need to be passed to the {{TriggerUtils.validProperties}} 
> method i.e. aboveOp, belowOp and maybe others too i.e. 
> aboveSize/belowSize/etc. Illustrative patch to follow. Thank you.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to