[GitHub] [lucene] mikemccand commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-17 Thread GitBox
mikemccand commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r633612119 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] mikemccand commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-17 Thread GitBox
mikemccand commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r633612119 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,379 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] mikemccand commented on a change in pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-14 Thread GitBox
mikemccand commented on a change in pull request #133: URL: https://github.com/apache/lucene/pull/133#discussion_r632584798 ## File path: lucene/facet/src/java/org/apache/lucene/facet/StringValueFacetCounts.java ## @@ -0,0 +1,371 @@ +/* + * Licensed to the Apache Software