[GitHub] cowwoc commented on a change in pull request #15: Don't fail if module source path already exists.

cowwoc commented on a change in pull request #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243866894 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @

[GitHub] cowwoc commented on a change in pull request #15: Don't fail if module source path already exists.

cowwoc commented on a change in pull request #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243866894 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ## @

[GitHub] cowwoc edited a comment on issue #15: Don't fail if module source path already exists.

cowwoc edited a comment on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449787790 @eolivelli Nevermind, I figured it out. There were numerous things wrong with the integration test. Namely: * Th

[GitHub] cowwoc commented on issue #15: Don't fail if module source path already exists.

cowwoc commented on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449787790 @eolivelli Nevermind, I figured it out. There were numerous things wrong with that commit. Namely: * The top-level pom w

[GitHub] cowwoc edited a comment on issue #15: Don't fail if module source path already exists.

cowwoc edited a comment on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449787790 @eolivelli Nevermind, I figured it out. There were numerous things wrong with the integration test. Namely: * Th

[GitHub] cowwoc edited a comment on issue #14: Exclude non-exported packages when Java Modules are present.

cowwoc edited a comment on issue #14: Exclude non-exported packages when Java Modules are present. URL: https://github.com/apache/maven-javadoc-plugin/pull/14#issuecomment-449783691 @rfscholte I've added an integration test, checked that it fails before the fix and further optimized the i

[GitHub] cowwoc commented on issue #14: Exclude non-exported packages when Java Modules are present.

cowwoc commented on issue #14: Exclude non-exported packages when Java Modules are present. URL: https://github.com/apache/maven-javadoc-plugin/pull/14#issuecomment-449783691 @rfscholte I've added an integration test, checked that it failed before the fix and further optimized the impleme

[GitHub] cowwoc commented on issue #15: Don't fail if module source path already exists.

cowwoc commented on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449779787 @eolivelli I am trying to invoke `javadoc:aggregate` twice in a row. I tried https://github.com/apache/maven-javadoc-plugin/pul

[jira] [Created] (MNG-6542) .mvn/maven.config is ignored when running "mvn dependency:tree"

wei created MNG-6542: Summary: .mvn/maven.config is ignored when running "mvn dependency:tree" Key: MNG-6542 URL: https://issues.apache.org/jira/browse/MNG-6542 Project: Maven Issue Type: Bug

[jira] [Commented] (SUREFIRE-1611) Deprecate skipTests in Failsafe Plugin

[ https://issues.apache.org/jira/browse/SUREFIRE-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728509#comment-16728509 ] Clément Guillaume commented on SUREFIRE-1611: - Out of curiosity, will ther

[GitHub] rfscholte commented on issue #14: Exclude non-exported packages when Java Modules are present.

rfscholte commented on issue #14: Exclude non-exported packages when Java Modules are present. URL: https://github.com/apache/maven-javadoc-plugin/pull/14#issuecomment-449762133 One of the most important instructions on https://github.com/apache/maven-javadoc-plugin is: > Run all the t

[GitHub] cowwoc commented on issue #15: Don't fail if module source path already exists.

cowwoc commented on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449759475 @rfscholte Fair enough, but I still need to understand how to write proper integration tests because https://github.com/apache

[GitHub] rfscholte commented on issue #15: Don't fail if module source path already exists.

rfscholte commented on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449759250 In this case an integration test is a little bit too much. The code is simple, touched often enough by other tests and a un

[GitHub] cowwoc commented on issue #15: Don't fail if module source path already exists.

cowwoc commented on issue #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#issuecomment-449758314 @eolivelli @rfscholte I'm new to integration tests in this plugin. I tried adding an integration test in https://github.com/ap

[GitHub] rfscholte commented on a change in pull request #15: Don't fail if module source path already exists.

rfscholte commented on a change in pull request #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243829942 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ##

[GitHub] eolivelli commented on a change in pull request #15: Don't fail if module source path already exists.

eolivelli commented on a change in pull request #15: Don't fail if module source path already exists. URL: https://github.com/apache/maven-javadoc-plugin/pull/15#discussion_r243828901 ## File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java ##

[jira] [Created] (MPLUGIN-347) No enum constant io.apigee.buildTools.enterprise4g.mavenplugin.DeployMojo.OPTIONS.none Failed to execute goal io.apigee.build-tools.enterprise4g:apigee-edge-maven-plugi

mahesh created MPLUGIN-347: -- Summary: No enum constant io.apigee.buildTools.enterprise4g.mavenplugin.DeployMojo.OPTIONS.none Failed to execute goal io.apigee.build-tools.enterprise4g:apigee-edge-maven-plugin:1.1.6:deploy Key: MPLUGIN-

[jira] [Comment Edited] (MPOM-209) The issueManagement entry points to wrong location.

[ https://issues.apache.org/jira/browse/MPOM-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728011#comment-16728011 ] Oscar Farga edited comment on MPOM-209 at 12/24/18 11:28 AM: - A

[jira] [Commented] (MASSEMBLY-850) Class-path ignores runtime dependencies

[ https://issues.apache.org/jira/browse/MASSEMBLY-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16728310#comment-16728310 ] Enrico Olivelli commented on MASSEMBLY-850: --- [~ondrej@devterium.cz] do y

[jira] [Updated] (MASSEMBLY-900) Upgrade plexus-archiver to 4.0.0

[ https://issues.apache.org/jira/browse/MASSEMBLY-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli updated MASSEMBLY-900: -- Fix Version/s: 3.1.1 > Upgrade plexus-archiver to 4.0.0 > --

[jira] [Resolved] (MASSEMBLY-861) exclusion * also packaged

[ https://issues.apache.org/jira/browse/MASSEMBLY-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli resolved MASSEMBLY-861. --- Resolution: Duplicate Fix Version/s: 3.1.1 > exclusion * also packaged > --

[jira] [Assigned] (MASSEMBLY-900) Upgrade plexus-archiver to 4.0.0

[ https://issues.apache.org/jira/browse/MASSEMBLY-900?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enrico Olivelli reassigned MASSEMBLY-900: - Assignee: Enrico Olivelli > Upgrade plexus-archiver to 4.0.0 > --

[jira] [Updated] (MSITE-831) The Sink.JUSTIFY_XXX has no effect

[ https://issues.apache.org/jira/browse/MSITE-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] QualiteSys QualiteSys updated MSITE-831: Description: Hello I wish to use custom column alignments in tables. The Sink.JUST

[jira] [Created] (MSITE-831) The Sink.JUSTIFY_XXX has no effect

QualiteSys QualiteSys created MSITE-831: --- Summary: The Sink.JUSTIFY_XXX has no effect Key: MSITE-831 URL: https://issues.apache.org/jira/browse/MSITE-831 Project: Maven Site Plugin Issu

[GitHub] rfscholte commented on issue #14: Exclude non-exported packages when Java Modules are present.

rfscholte commented on issue #14: Exclude non-exported packages when Java Modules are present. URL: https://github.com/apache/maven-javadoc-plugin/pull/14#issuecomment-449700259 Can you add your testcase to `src/it` to confirm this fixes the assue and to prevent regression in the future.