[jira] [Commented] (SUREFIRE-1745) Global Junit Test timeout

2020-01-23 Thread Kishore Kumar (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022731#comment-17022731 ] Kishore Kumar commented on SUREFIRE-1745: - I tried forkedProcessTimeoutInSecon

[GitHub] [maven-release] theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370493856 ## File path: maven-release-api/src/main/java/org/apache/mave

[GitHub] [maven-release] theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370493975 ## File path: maven-release-manager/src/main/java/org/apache/

[GitHub] [maven-release] theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370493950 ## File path: maven-release-manager/src/main/java/org/apache/

[GitHub] [maven-release] theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370493887 ## File path: maven-release-manager/src/main/java/org/apache/

[GitHub] [maven-release] theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370493806 ## File path: maven-release-api/src/main/java/org/apache/mave

[GitHub] [maven-release] theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
theit commented on issue #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#issuecomment-578012895 @michael-o: I thought about a test, but honestly I don't know if that makes sense. This

[jira] [Commented] (SUREFIRE-1747) spring-boot-maven-plugin with goal repackage make tests to silently not execute

2020-01-23 Thread Atle Tokle (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022707#comment-17022707 ] Atle Tokle commented on SUREFIRE-1747: -- [~tibordigana] That was not the problem.

[jira] [Updated] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1633: --- Fix Version/s: Backlog > [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run w

[jira] [Updated] (SUREFIRE-1727) Failures during test template creation are ignored

2020-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1727: --- Fix Version/s: Backlog > Failures during test template creation are ignored >

[jira] [Closed] (SUREFIRE-1747) spring-boot-maven-plugin with goal repackage make tests to silently not execute

2020-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1747. -- Assignee: Tibor Digana Resolution: Not A Problem The problem is that you did not add {

[GitHub] [maven-doxia-linkcheck] elharo opened a new pull request #1: DOXIATOOLS-54: make LinkMatcher thread safe

2020-01-23 Thread GitBox
elharo opened a new pull request #1: DOXIATOOLS-54: make LinkMatcher thread safe URL: https://github.com/apache/maven-doxia-linkcheck/pull/1 @michael-o This was a classic example of premature optimization. This is an automate

[jira] [Comment Edited] (DOXIATOOLS-54) LinkMatcher uses a singleton set

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022520#comment-17022520 ] Elliotte Rusty Harold edited comment on DOXIATOOLS-54 at 1/23/20 9:36 PM: --

[GitHub] [maven-surefire] qerub commented on issue #262: Refer to correct property in skipping-tests doc

2020-01-23 Thread GitBox
qerub commented on issue #262: Refer to correct property in skipping-tests doc URL: https://github.com/apache/maven-surefire/pull/262#issuecomment-577888150 I think we're mixing up three different issues here: 1. what the author of the current documentation had in mind when they wrote

[jira] [Commented] (DOXIATOOLS-54) LinkMatcher uses a singleton set

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022520#comment-17022520 ] Elliotte Rusty Harold commented on DOXIATOOLS-54: - This has now moved

[jira] [Commented] (SUREFIRE-1745) Global Junit Test timeout

2020-01-23 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022445#comment-17022445 ] Tibor Digana commented on SUREFIRE-1745: Try to use {{forkedProcessTimeoutInSe

[jira] [Commented] (MNG-6848) Ci Friendly builds broke with 3.6.2

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022264#comment-17022264 ] Michael Osipov commented on MNG-6848: - [~Jason Mathison], can you strip down your proje

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022262#comment-17022262 ] Michael Osipov commented on WAGON-575: -- Let's wait for the debug logs. > Retry for c

[jira] [Commented] (MNG-6848) Ci Friendly builds broke with 3.6.2

2020-01-23 Thread Jason Mathison (Jira)
[ https://issues.apache.org/jira/browse/MNG-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022259#comment-17022259 ] Jason Mathison commented on MNG-6848: - I was able to work on the merge to the point tha

[jira] [Updated] (DOXIATOOLS-59) Link checker not handling anchors of fluido skin topbar very well

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated DOXIATOOLS-59: Issue Type: Bug (was: Improvement) > Link checker not handling anchors

[jira] [Resolved] (DOXIATOOLS-55) Drop httpclient

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved DOXIATOOLS-55. - Resolution: Not A Problem Based on the PR it looks like this isn't goi

[jira] [Updated] (DOXIATOOLS-55) Drop httpclient

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated DOXIATOOLS-55: Issue Type: Dependency upgrade (was: New Feature) > Drop httpclient > -

[jira] [Resolved] (DOXIATOOLS-56) doxia-book-renderer has unit test errors

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-56?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved DOXIATOOLS-56. - Resolution: Duplicate Duplicate of 64 which is now fixed > doxia-book

[jira] [Resolved] (DOXIATOOLS-64) Flaky test DocBookBookSinkTest

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved DOXIATOOLS-64. - Resolution: Fixed > Flaky test DocBookBookSinkTest > -

[jira] [Created] (SUREFIRE-1747) spring-boot-maven-plugin with goal repackage make tests to silently not execute

2020-01-23 Thread Atle Tokle (Jira)
Atle Tokle created SUREFIRE-1747: Summary: spring-boot-maven-plugin with goal repackage make tests to silently not execute Key: SUREFIRE-1747 URL: https://issues.apache.org/jira/browse/SUREFIRE-1747 P

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Oleg Kalnichevski (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022158#comment-17022158 ] Oleg Kalnichevski commented on WAGON-575: - [~michael-o] HttpClient with default se

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Medin (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022154#comment-17022154 ] Michael Medin commented on WAGON-575: - This was without any particular config but I ge

[jira] [Comment Edited] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-01-23 Thread Douglas Silva (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022148#comment-17022148 ] Douglas Silva edited comment on SUREFIRE-1633 at 1/23/20 2:22 PM: --

[jira] [Commented] (SUREFIRE-1633) [JUnit5 follow-up #1343] JUnit Jupiter @Nested tests do not run when selecting enclosing class with Surefire

2020-01-23 Thread Douglas Silva (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022148#comment-17022148 ] Douglas Silva commented on SUREFIRE-1633: - Just put an '*' after name of outer

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022096#comment-17022096 ] Michael Osipov commented on WAGON-575: -- [~olegk], I assume that the old and the new

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Medin (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022094#comment-17022094 ] Michael Medin commented on WAGON-575: - Same thing with Java 8 (Exception is not wrappe

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Medin (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022082#comment-17022082 ] Michael Medin commented on WAGON-575: - Nothing seems changed in 2020-01-15 build of Ja

[jira] [Assigned] (DOXIATOOLS-64) Flaky test DocBookBookSinkTest

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned DOXIATOOLS-64: --- Assignee: Elliotte Rusty Harold > Flaky test DocBookBookSinkTest

[jira] [Commented] (DOXIATOOLS-64) Flaky test DocBookBookSinkTest

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022032#comment-17022032 ] Elliotte Rusty Harold commented on DOXIATOOLS-64: - Repo is migrated. T

[jira] [Commented] (DOXIATOOLS-54) LinkMatcher uses a singleton set

2020-01-23 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022031#comment-17022031 ] Elliotte Rusty Harold commented on DOXIATOOLS-54: - [https://github.com

[GitHub] [maven-release] michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370070779 ## File path: maven-release-api/src/main/java/org/apache/

[GitHub] [maven-release] michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370072056 ## File path: maven-release-manager/src/main/java/org/apa

[GitHub] [maven-release] michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370071275 ## File path: maven-release-manager/src/main/java/org/apa

[GitHub] [maven-release] michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370071421 ## File path: maven-release-manager/src/main/java/org/apa

[GitHub] [maven-release] michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations

2020-01-23 Thread GitBox
michael-o commented on a change in pull request #32: [MRELEASE-549] Add support for the "--pin-externals" operations in SCM branch and tag operations URL: https://github.com/apache/maven-release/pull/32#discussion_r370070674 ## File path: maven-release-api/src/main/java/org/apache/

[GitHub] [maven] rosti-il commented on issue #318: [MNG-6853] - Don't box primitives where it's not needed

2020-01-23 Thread GitBox
rosti-il commented on issue #318: [MNG-6853] - Don't box primitives where it's not needed URL: https://github.com/apache/maven/pull/318#issuecomment-577638662 @olamy This can only improve the performance because the `Integer.valueOf()` calls to the `Integer.parseInt()` by itself. The `Inte

[GitHub] [maven-surefire] Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication.

2020-01-23 Thread GitBox
Tibor17 commented on issue #240: [SUREFIRE-1658] TCP/IP Channel for forked Surefire JVM. Extensions API and SPI. Polymorphism for remote and local process communication. URL: https://github.com/apache/maven-surefire/pull/240#issuecomment-577630204 @eolivelli The master fails in Travis

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021911#comment-17021911 ] Michael Osipov commented on WAGON-575: -- That might be true, but I like to see the raw

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Medin (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021883#comment-17021883 ] Michael Medin commented on WAGON-575: - I went down that route myself and thats why I w

[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader

2020-01-23 Thread GitBox
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577597199 @slachiewicz , there was no reaction except yours. As I have wrote in this PR, this plugin is used in two places and it is not cl

[GitHub] [maven-verifier-plugin] michael-o commented on issue #2: [MVERIFIER-38] Define encoding for FileReader

2020-01-23 Thread GitBox
michael-o commented on issue #2: [MVERIFIER-38] Define encoding for FileReader URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577597085 Why not use source encoding defined in the POM? This is an auto

[jira] [Commented] (WAGON-575) Retry for connection issues

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021879#comment-17021879 ] Michael Osipov commented on WAGON-575: -- Let me guess, you are using Java 11? You have

[GitHub] [maven-verifier-plugin] slachiewicz commented on issue #2: [MVERIFIER-38] Define encoding for FileReader

2020-01-23 Thread GitBox
slachiewicz commented on issue #2: [MVERIFIER-38] Define encoding for FileReader URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577595394 Thx for reminder - please look for discussion on maven-dev mailing list --

[GitHub] [maven-verifier-plugin] KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader

2020-01-23 Thread GitBox
KroArtem commented on issue #2: [MVERIFIER-38] Define encoding for FileReader URL: https://github.com/apache/maven-verifier-plugin/pull/2#issuecomment-577594477 @slachiewicz, ping again 😃 This is an automated message from th

[jira] [Commented] (DOXIATOOLS-64) Flaky test DocBookBookSinkTest

2020-01-23 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIATOOLS-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021875#comment-17021875 ] Michael Osipov commented on DOXIATOOLS-64: -- This is logically wrong. you cann